Code review comment for lp://qastaging/~johannes.erdfelt/nova/deferred-delete-instance

Revision history for this message
Brian Lamar (blamar) wrote :

Awesomeness. Only a single question remains for me about the Compute API:

soft_delete
delete
restore
force_delete

These 4 methods seem to have a little overlap and I think delete/force_delete end up doing the exact same thing? Would you be up for just having:

delete
soft_delete
restore

Might be able to just check for _is_queued_delete or _is_able_to_shutdown in delete and it would remove the need for force_delete?

Great stuff.

review: Needs Information

« Back to merge proposal