Code review comment for lp://qastaging/~johannes.erdfelt/nova/deferred-delete-instance

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> I really think deploying a different configuration for API and compute is a
> bad idea. If you make a mistake, you can easily end up in a situation where
> instances are never deleted (soft delete enabled on API, but interval not set
> on compute).

I understand the concern, but these are different services with very different jobs. I would *expect* people to use different configuration files. We can fix the case outlined above by defaulting the interval to 120 or something, requiring it is above 0 if soft delete is enabled.

> Are there any other examples where a feature is enabled on API, but configured
> on compute?

Nothing jumps out at me. I don't think it is necessarily a bad thing... Let's get an outside opinion on this.

« Back to merge proposal