Code review comment for lp://qastaging/~johannes.erdfelt/nova/deferred-delete-instance

Revision history for this message
Chris Behrens (cbehrens) wrote :

Looks good. I like the delete filtering implementation to solve the deleted instances showing up problem. You could actually just do:

if filters.get('deleted', False):
   .. code for True
else:
   .. code for False

Removing 'deleted' from the list of direct match names causes it to be ignored below this code IIRC, so you don't really need to pop it out of the dict. Even if you wanted to pop it out, you could s/get/pop/ above.

But, I'm good with it how it is.

review: Approve

« Back to merge proposal