Code review comment for lp://qastaging/~johannes.erdfelt/nova/deferred-delete-instance

Revision history for this message
Chris Behrens (cbehrens) wrote :

Well, I just ran into an issue in trunk with the part of this merge prop that merged already.

openstack/api/servers.py references that reclaim_instance_interval flag that's defined in compute/manager.py.. but it doesn't import compute.manager

I'm guessing at runtime, it's probably imported elsewhere... but I have a test in a branch I'm working on that is failing because of this. It feels like this should be fixed in some way correctly in this branch. For now, in my branch, I've just added the import to servers.py even though we don't use manager at all there.

review: Needs Fixing

« Back to merge proposal