Yes, we do not want everything to be executable, because... well, they aren't. Attempts to run the vast majority of these things will blow up in your face (no #! magic to point it to a python interpreter). Please fix that.
You've added a duplicate "import sys" in nova-compute
Is there any parts of the win32serviceutil framework that forces a specific naming scheme for classes? If not, please change the class name to match our usual style ("ComputeWin32Service").
> + #Trying to use code directly from vish/libvirt for portability
I don't understand this comment?
Also, some unit tests for all of this would be really nice. I'm have no Windows machines for testing, so I have no way to know if I'll be breaking your code.
Yes, we do not want everything to be executable, because... well, they aren't. Attempts to run the vast majority of these things will blow up in your face (no #! magic to point it to a python interpreter). Please fix that.
You've added a duplicate "import sys" in nova-compute
> +class compute_ win32_service( win32serviceuti l.ServiceFramew ork):
Is there any parts of the win32serviceutil framework that forces a specific naming scheme for classes? If not, please change the class name to match our usual style ("ComputeWin32S ervice" ).
> + #Trying to use code directly from vish/libvirt for portability
I don't understand this comment?
Also, some unit tests for all of this would be really nice. I'm have no Windows machines for testing, so I have no way to know if I'll be breaking your code.