Code review comment for lp://qastaging/~josharenson/unity8/fix-default-session

Revision history for this message
Michael Terry (mterry) wrote :

Seems good to me, but might this not be better done at the Model level? Rather than have the View massage data? Much like we modify user name data if it's empty.

setCurrentSession() feels like it belongs in Greeter or a piece of code shared between Wide and Narrow views... But I think my greeter-arrangement branch does that (I should dust that off, fix its tests, and re-propose).

Tests didn't pass, for unrelated reason.

Nice test addition.

review: Needs Information

« Back to merge proposal