Code review comment for lp://qastaging/~jr/bzr/274578-smart-server-hookable-error-logging

Looks good, thanks !

One small nit:

70 + args = []
71 + out, err = self.run_bzr_serve_then_func(args, retcode=3)

This checks that the server dies when no hook is installed (before testing the hook itself).

It would be even better to do that in a separate test to get a better defect localization (see http://xunitpatterns.com/Goals%20of%20Test%20Automation.html).

You also need to add a news entry (make sure to remerge trunk so you get the right section in the release-notes file).

BB:tweak ;)