OpenStack Compute (nova)

Merge lp://qastaging/~jshepher/nova/lp850289 into lp://qastaging/~hudson-openstack/nova/trunk

lp850289
Merge into trunk

Proposed by Justin Shepherd on 2011-09-15

Status:

Needs review

Proposed branch:

lp://qastaging/~jshepher/nova/lp850289

Merge into:

lp://qastaging/~hudson-openstack/nova/trunk

Diff against target:

11 lines (+1/-0)

1 file modified

bin/nova-manage (+1/-0)

To merge this branch:

bzr merge lp://qastaging/~jshepher/nova/lp850289

Undecided

Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
Vish Ishaya (community)		2011-09-15	Disapprove on 2011-09-15
Review via email: mp+75612@code.qastaging.launchpad.net

Description of the change

Imported nova/service.py to add the flags defined in that file into the "nova-manage --help" output.

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2011-09-15:

why do we need those flags in nova_manage --help? They aren't used by nova-manage.

review: Needs Information

Revision history for this message

Justin Shepherd (jshepher) wrote on 2011-09-15:

Mostly, from a sysadmin point of view.. the most common way to figure out what flags to populate your nova.conf file with is to run "nova-manage --help".

--shep

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2011-09-15:

hmm. I don't think this is the right approach. Nova-manage will not bring in any flags from dynamically loaded extensions, etc. Importing a module that is not used will give a pylint error. The proper way to pull in other flags if you don't need to import the file is with flags.DECLARE, but since the flags aren't actually used I'm not so sure that is right either. Perhaps we could have a nova-manage flags command that would try to import every file in the tree and then print --help?

review: Disapprove

Revision history for this message

Justin Shepherd (jshepher) wrote on 2011-09-15:

Vish, I can definitely agree that this might not be the best way to solve this problem.

I am just not sure what the right way is.. in a normal situation i think the correct way would be a man file for nova.conf that contains definitions of all the flags, and their default values. But i think the codebase is moving too quickly for this to stay current.