Files

Merge lp://qastaging/~junrrein/pantheon-files/fix-1005270 into lp://qastaging/~elementary-apps/pantheon-files/trunk

  1. fix-1005270
  2. Merge into trunk
Proposed by Julián Unrrein
Status: Merged
Merged at revision: 1087
Proposed branch: lp://qastaging/~junrrein/pantheon-files/fix-1005270
Merge into: lp://qastaging/~elementary-apps/pantheon-files/trunk
Diff against target: 68 lines (+17/-11)
2 files modified
libcore/gof-file.c (+7/-1)
src/marlin-places-sidebar.c (+10/-10)
To merge this branch: bzr merge lp://qastaging/~junrrein/pantheon-files/fix-1005270
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Julián Unrrein (community) Needs Resubmitting
Review via email: mp+144033@code.qastaging.launchpad.net

Description of the change

Force the trash folder to be recognised as writable. Fixes bug #1005270

To post a comment you must log in.
Revision history for this message
Julián Unrrein (junrrein) wrote :

There is a new bug now. When dragging something to the trash using the secondary button, the "Copy" and "Link" menu items appear, and that shouldn't happen. Thankfully, sellecting either fails gracefully with an error message.

review: Needs Fixing
lp://qastaging/~junrrein/pantheon-files/fix-1005270 updated
1083. By Julián Unrrein

When secondary-dragging items to the trash, make the "Move" action the only available one.

Revision history for this message
Julián Unrrein (junrrein) wrote :

Now it should work properly.

review: Needs Resubmitting
Revision history for this message
Julián Unrrein (junrrein) wrote :

Oops, I'm sorry about the "Resubmit" thingy.

Revision history for this message
David Gomes (davidgomes) wrote :

if (!g_file_info_has_attribute (file->info, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE)){
↓
if (!g_file_info_has_attribute (file->info, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE)) {

The rest isn't absolutely perfect, but it's fine. We don't have super-strict C Code Guidelines anyways.

Revision history for this message
Julián Unrrein (junrrein) wrote :

Please point out those imperfections you are talking about, so I can take them in mind next time at least.

lp://qastaging/~junrrein/pantheon-files/fix-1005270 updated
1084. By Julián Unrrein

Improve the coding style.

Revision history for this message
David Gomes (davidgomes) wrote :

It's good code now man :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: