Code review comment for lp://qastaging/~justin-fathomdb/nova/add-xsd

Revision history for this message
justinsb (justin-fathomdb) wrote :

Sure! Technically though, this one isn't subject to FF, because this is not a Feature, this is to support a bugfix for Bug #740576. It was linked, but 'someone' unlinked it ;-) The bug is that our XML API isn't to spec. This is the spec :-)

Risks:
I do believe there's as close to zero risk as is possible - these files aren't even referenced. If they are referenced in future, they'll likely initially be referenced only by tests (validating our XML against the schema). If they are referenced by non-tests, it will be because it's the most efficient way to deliver a correct XML API.

Benefits:
By having the spec in the codebase, we're able to validate against it.

I was planning on writing tests using the Java bindings.

« Back to merge proposal