Code review comment for lp://qastaging/~justin-fathomdb/nova/add-xsd

Revision history for this message
Soren Hansen (soren) wrote :

Now, if this was accompanied by some tests that actually used it, I could see its value. As is, it's an XML Schema that *something else* (the existing Rackspace Cloud Servers) validates against. I think having this in the tree while we're not even sure we validate against it is confusing, and I don't think I understand its value.

If you can add some tests that actually use it, I'd be happy to accept it even much later in the cycle. Alternativaly, (much less idealy) if you could document that you've used some external tool to validate our stuff against this schema and it actually passes, I think it'll make much mose sense to have this in the tree as some kind of documentation.

review: Disapprove

« Back to merge proposal