Code review comment for lp://qastaging/~justin-fathomdb/nova/add-xsd

Revision history for this message
Vish Ishaya (vishvananda) wrote :

Sorem, Brian:

Do you still feel this is a disapprove now that we have a branch with tests? I'm leaning toward getting this in so we can start fixing the issues that the tests expose. I'm not concerned about this making it into cactus specifically, but it seems like there is a reason for this to be there now.

« Back to merge proposal