Code review comment for lp://qastaging/~justin-fathomdb/nova/justinsb-api-fix-imageid
Revision history for this message
| justinsb (justin-fathomdb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Dictionary .get never throws KeyError; if the second arg isn't specified it return None if the key isn't present, so I think that's OK.
I think that if we had an imageId of 0 or '' or another value that is False in Python, we'd break everywhere, so I'd prefer to leave it as-is for clarity. Happy to fix if others disagree though...