Code review comment for lp://qastaging/~justin-fathomdb/nova/justinsb-api-fix-imageid

Revision history for this message
Jay Pipes (jaypipes) wrote :

>
> > We are forcing integer identifiers now?
> > -jay
>
>
> I wouldn't use the word 'force'. The idea is that the image services are
> standardized. Given that some API's (aka the openstack API) require an actual
> ID parameter I think this makes sense.

You wrote "I've re-factored the image services so that S3 and Glance image objects all implement an integer ID". That is forcing in my opinion.

Glance does not require image identifiers to be integers, so making this change in Nova will break any Glance registry that uses non-integer keys.

> The branch I'm proposing actually removes quite a bit of the translation code
> up in the images API layers just by standardizing the interfaces.

That's fine in my book, I was just complaining about forcing integer keys.

-jay

« Back to merge proposal