Merge lp://qastaging/~justin-fathomdb/nova/justinsb-fix-pep8 into lp://qastaging/~hudson-openstack/nova/trunk

Lgtm

Strangely, pep8 didn't complain for me when I ran it on the uncorrected file. I'm curious which rule was violated. Have any output here?

(As a sanity check, I purposefully inserted a pep8 violation, and it *did* complain in that instance)

Rick: Sure... I definitely am all for getting to the bottom of this! It's annoying, but I can live with it for a while, so we should definitely figure out how the pep8 violation snuck in if that's what happened, or what's different about how I'm running pep8 vs the test suite and which way is right... Details below.

My pep8 version:
pep8 --version
0.5.0

Here's the violation error:
nova/tests/api/openstack/test_zones.py:60:36: E202 whitespace before ']'
                 password='qwerty')
                                   ^
    Avoid extraneous whitespace in the following situations:

    - Immediately inside parentheses, brackets or braces.

    - Immediately before a comma, semicolon, or colon.

    Okay: spam(ham[1], {eggs: 2})
    E201: spam( ham[1], {eggs: 2})
    E201: spam(ham[ 1], {eggs: 2})
    E201: spam(ham[1], { eggs: 2})
    E202: spam(ham[1], {eggs: 2} )
    E202: spam(ham[1 ], {eggs: 2})
    E202: spam(ham[1], {eggs: 2 })

    E203: if x == 4: print x, y; x, y = y , x
    E203: if x == 4: print x, y ; x, y = y, x
    E203: if x == 4 : print x, y; x, y = y, x

> pep8 --version
> 0.5.0

Ah, looks like you're running an older version of pep8. I'm assuming since you're the first to notice it, we're probably all running the newer version (> 0.6).

My version:

$ pep8 --version
0.6.1

Hmm, I just noticed that our `tools/pip-requires` file includes this line:

pep8==0.5.0

Wondering if we should bump that up to the 0.6 version now?

It does indeed disappear with pep8 version == 0.6.1 (which is the version I just got from easy_install pep8). I was previously running the apt-get version on Maverick (0.5.0).

I'm guessing that the pep8 police decided that this should be decriminalized, so we can close this merge request?

> so we can close this merge request?

Yep, I think we should close this without merge.

I've reported the pip-requires issue here https://bugs.launchpad.net/nova/+bug/721867

Thanks for raising this, it'll be nice to get everyone standardized on the more recent version of pep8.

Bug report looks like the right way to handle this. Moved to 'work in progress' as we'll lose the comments here if I delete it.