Code review comment for lp://qastaging/~justin-fathomdb/nova/justinsb-openstack-api-keys

Revision history for this message
justinsb (justin-fathomdb) wrote :

1) Quite right Jay & very sorry NASA/Anso guys! I started with a clean file and then didn't update the copyright as I refactored the code into there.

2) The idea of the Keys class is to make it look like volumes, network, images & compute. Each of the Web services instantiates a service.API class, and then makes calls on it. Although it's in-process at the moment, and thus could be a module, the intention is that this is an implementation detail. I renamed it to API to show this and added a comment. I did fix up the imports as you suggested.

3) This is necessary to support testing, which is needed for our goal of stability. However, until it has been approved by the community, it is disabled unless specifically enabled for testing, just like FLAGS.allow_admin_api. I called this flag FLAGS.allow_testing_api

4) Done! (Taking advantage of #3!)

« Back to merge proposal