Code review comment for lp://qastaging/~justin-fathomdb/nova/justinsb-openstack-api-volumes

Revision history for this message
Jay Pipes (jaypipes) wrote :

> Jay: I think that starting services in-process is a nice way to do this in
> tests, rather than relying on a 'deus ex machina', because that way you can
> start services on unused ports (particularly useful when you want multiple
> services), or start them with different configs, or get access to internal
> state for testing etc.

This is exactly what we do in Glance. :) We don't start the bin/glance-api "in process" in the functional tests because I've found that there are a number of things that come up when you start a process daemonized that were being masked by the in-process stuff (like logging)

> The WSGI shutdown broken thing is why I wanted known_bugs. That's a no-go,
> so I can either leave it commented out or just delete it. I think commented
> out is better.

Ah, ok. Well, the note and commented out is fine I suppose. Just file a bug on it ;)

> Otherwise I'm going to do a cleanup when this branch's pre-reqs are approved
> for merge.

I only know of the one pre-req (servicify). Are you referring to others? (keys, perhaps?)

-jay

« Back to merge proposal