Code review comment for lp://qastaging/~justin-fathomdb/nova/output-xml-in-order

The diff created by launchpad seems to be missing a lot. For example, you added a api/openstack/validation.py in rev 849. Nowhere in the diff is that file referenced. I also don't see the changes you made in wsgi.py. This probably isn't your fault, I just wanted to point this out to other reviewers. I used the following command to generate a diff:

bzr diff lp:~justin-fathomdb/nova/output-xml-in-order --old=lp:nova/trunk -r 949

So it looks like this branch does more than "Allow XML elements to be listed, and then output in that order". Can you expand on that?

Does this branch also depend on lp:~justin-fathomdb/nova/add-xsd? Otherwise, why are you adding all of the xsd files in this branch?

I also noticed "# NOTE(justinsb): Commented out for now because it finds too many issues" in fake_flags.py. Is this the right approach to take? Why don't we address the "issues" before we merge this in?

Can you explain what the "validate_xml_for_json" flag means?