Code review comment for lp://qastaging/~justin-fathomdb/nova/output-xml-in-order
Revision history for this message
| justinsb (justin-fathomdb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> With your logic, we could use XML objects to represent things internally, then serialize it to JSON in a response.
Do you mean using strongly typed domain objects, so that we wipe out half our bugs in a single stroke? Sounds good to me!
> This brings me back to my point above, what real value are we getting if we don't strictly enforce the schemas?
I agree; without being spec-compliant the API has greatly reduced value to callers. The XML guys will fail validation, the JSON guys will tear their hair out trying to figure out why the docs are wrong.
I'm proposing we incorporate the schema so that we can fix up the API. I'd love to enforce it strictly so that everyone _had_ to fix their APIs, but we can't do that in this development process. You're free to tweak the flags and tell your team to get on it though.