Code review comment for lp://qastaging/~justin-fathomdb/nova/skip-validation-openstack11

Revision history for this message
termie (termie) wrote :

Ah, I see here where the flag I was discussing in the other patch is defined.

As a somewhat arbitrary stylistic approach for XML in python, I feel that the current best library is etree rather than minidom, the syntax is much more pythonic (and no mixedCase) and requires less push-ups than DOM. Not gating this patch in any way, but worth looking into.

For example, most of the foo.getAttribute('bar', 'baz') would just be foo.get('bar', 'baz')

review: Approve

« Back to merge proposal