Code review comment for lp://qastaging/~justin-fathomdb/nova/strongly-typed-image-model

META: I like the concept of having code & discussion in the same place. I'm also good with having code pre-blueprint or discussion, since we all understand code, probably more-so than English in a lot of cases. I just wish we could comment inline with the code :(. I agree this isn't a big enough idea to require summit discussion, unless we want to make it about preferring objects to hashes in general and talking about the places those are used and their ramifications (eg, serialization over the queue).

As far as this patch, I like the direction it is going. It probably needs a rebase and should take into account some of the changes that went in today: http://bazaar.launchpad.net/~hudson-openstack/nova/trunk/revision/768.

I trust in the final version you'll remove the dead code that is hiding in comments (since KeyError shouldn't be raised anymore anyway).

I don't particularly like the PyLint hacks. I don't mind type-checking the incoming parameter so much as I mind returning after a raise. Is there no way to give pylint inference hints in comments?