Code review comment for lp://qastaging/~justin-fathomdb/nova/strongly-typed-image-model

Revision history for this message
justinsb (justin-fathomdb) wrote :

Devin: Sounds like you agree that Dicts are problematic, and agree with the object approach. This is only a proof-of-concept branch, but you're right - even if it is was rebased, we probably want to consider the whole codebase (though we'll still have to start somewhere!)

Thierry has suggested a Design Summit discussion on this issue; I think that maybe we could have one for the 'big picture' of removing Dicts and in general trying to get more help from PyLint and Python. "Engineering in quality". I feel we have a lot of rules about code formatting, but comparatively few about writing quality code or defensive code.

Thierry: How can I propose this as a topic for the design summit?

If I can do that, I think I'll close out this merge request (but link to it), as I feel that's a reasonable path forward. It doesn't seem like anyone is standing up in support of Dicts :-)

« Back to merge proposal