Code review comment for lp://qastaging/~kaaveeacs/drizzle/privatized-members-of-NestedJoin

Hi Kaaveea ,

On Thu, Apr 14, 2011 at 9:42 PM, Kaaveea C S <email address hidden> wrote:
> +  /*
> +    This constructor serves for creation of NestedJoin instances
> +  */
> +  NestedJoin()
> +  :
> +  join_list(),

Is it necessary to list join_list here?
Is the constructor needed at all?

> +  List<Item> getSjOuterExprList() const

Shouldn't this be returned by const&?

Greetings,

--
Olaf