Code review comment for lp://qastaging/~kalebral-deactivatedaccount/drizzle-automation/drizzle-automation-crashme

Revision history for this message
Jay Pipes (jaypipes) wrote :

Hi! Great work! Just a few tiny things...

1)

193 + time.sleep(3)

You can remove that. The server.stop() method takes care of this.

2)

172 + FILE= open(output_filename,"w")

Please have variables named with undercored names.

So, I recommend something like:

output_file= open(output_filename,"w")

3)

266 - from_string= ('%s <email address hidden>' % socket.gethostname())
267 + from_string= ('%s <email address hidden>' % socket.gethostname())

Hmmm, I don't think this is future-proof :)

Make those simple cleanups and I'll merge immediately.

Great work, Lee!

Jay

review: Needs Fixing

« Back to merge proposal