Code review comment for lp://qastaging/~kalebral-deactivatedaccount/drizzle-automation/update-lcov

Revision history for this message
Jay Pipes (jaypipes) wrote :

One tiny thing needs to be fixed. Other than that, looks good :)

497 - logging.error("Failed to generate LCOV HTML coverage report. Got error: %s" % output)
498 + logging.error("Failed to generate LCOV HTML coverage report. Got error after running %s" % (cmd,output))

Note that there is an incorrect number of placeholders in line 498's format string. You probably meant to put "Failed to generate LCOV HTML coverage report. Got error %s after running %s" % (output, cmd)

review: Needs Fixing

« Back to merge proposal