Looks nice! I didn't check out the SC branch, so didn't test it fully, but at least I tested the db-not-there case.
Just a couple minor things:
455 + public Database () throws GLib.IOError; you're throwing GFileError, so either "throws FileError" or just "throws Error".
180 + ratings.query (pkginfo.package_name, out result); perhaps it'd better to enclose it in an "if" considering it returns bool
362 + out_result->pkgname = pkgname; a bit dangerous, but as long as it's not really used...
But all in all, approve! :)
« Back to merge proposal
Looks nice! I didn't check out the SC branch, so didn't test it fully, but at least I tested the db-not-there case.
Just a couple minor things:
455 + public Database () throws GLib.IOError;
you're throwing GFileError, so either "throws FileError" or just "throws Error".
180 + ratings.query (pkginfo. package_ name, out result);
perhaps it'd better to enclose it in an "if" considering it returns bool
362 + out_result->pkgname = pkgname;
a bit dangerous, but as long as it's not really used...
But all in all, approve! :)