LAVA Android Test

Merge lp://qastaging/~kejun-zhou/lava-android-test/ime into lp://qastaging/lava-android-test

  1. ime
  2. Merge into trunk
Proposed by Kejun ZHOU
Status: Merged
Merged at revision: 171
Proposed branch: lp://qastaging/~kejun-zhou/lava-android-test/ime
Merge into: lp://qastaging/lava-android-test
Diff against target: 83 lines (+64/-0) (has conflicts)
3 files modified
MANIFEST.in (+4/-0)
lava_android_test/test_definitions/ime.py (+47/-0)
lava_android_test/test_definitions/ime/ime_test.sh (+13/-0)
Text conflict in MANIFEST.in
To merge this branch: bzr merge lp://qastaging/~kejun-zhou/lava-android-test/ime
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Le Chi Thu Pending
Kejun ZHOU Pending
Review via email: mp+107183@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-05-23.

Description of the change

This test is for checking which input methods are running in the Android system. The test runs the tool /system/bin/ime to show all the input method services.

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote : Posted in a previous version of this proposal

68 + echo "ime = pass"

this line seems not match the pattern defined in
43 +PATTERN = "^\s*(?P<test_case_id>\w+)=(?P<result>\w+)\s*$"

I think you can change to [echo "ime=pass"]

Revision history for this message
Yongqin Liu (liuyq0307) wrote : Posted in a previous version of this proposal

also, you should modify MANIFEST.in file

review: Needs Fixing
Revision history for this message
Le Chi Thu (le-chi-thu) wrote : Posted in a previous version of this proposal

Please describe the purpose of this test and what the test perform. Which input is required and expect conditions /outputs to detect when the test is pass or not.

echo "ime=unexist" should be echo "ime=fail"

review: Needs Fixing
Revision history for this message
Le Chi Thu (le-chi-thu) wrote : Posted in a previous version of this proposal

Please describe the purpose of this test and what the test perform. Which input is required and expect conditions /outputs to detect when the test is pass or not.

review: Needs Fixing
Revision history for this message
Alexander Sack (asac) wrote :

Kenjun resubmitted, can someone review?

Revision history for this message
Alexander Sack (asac) wrote :

sorry... wrong merge request... ignore my previous comment here.

Revision history for this message
Kejun ZHOU (kejun-zhou) wrote : Posted in a previous version of this proposal

The MANIFEST.in had been modify at 2012-04-26 03:16:07 UTC

include lava_android_test/test_definitions/gatortest/*
+include lava_android_test/test_definitions/ime/*

review: Needs Resubmitting
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

By this line
51 +PATTERN = "^\s*(?P<test_case_id>\w+)=(?P<result>\w+)\s*$"
many lines of the output will be matched.
Because the output of "/system/bin/ime list -a" like below:

com.android.inputmethod.latin/.LatinIME:
  mId=com.android.inputmethod.latin/.LatinIME mSettingsActivityName=com.android.inputmethod.latin.Settings
  mIsDefaultResId=0x7f080000
  Service:
    priority=0 preferredOrder=0 match=0x108000 specificIndex=-1 isDefault=false
    ServiceInfo:
      name=com.android.inputmethod.latin.LatinIME
      packageName=com.android.inputmethod.latin
      labelRes=0x7f0b0075 nonLocalizedLabel=null icon=0x0
      enabled=true exported=true processName=com.android.inputmethod.latin
      permission=android.permission.BIND_INPUT_METHOD
      flags=0x0
jp.co.omronsoft.openwnn/.OpenWnnJAJP:
  mId=jp.co.omronsoft.openwnn/.OpenWnnJAJP mSettingsActivityName=jp.co.omronsoft.openwnn.OpenWnnControlPanelJAJP
  mIsDefaultResId=0x0
  Service:
    priority=0 preferredOrder=0 match=0x108000 specificIndex=-1 isDefault=false
    ServiceInfo:
      name=jp.co.omronsoft.openwnn.OpenWnnJAJP
      packageName=jp.co.omronsoft.openwnn
      labelRes=0x0 nonLocalizedLabel=Japanese IME icon=0x0
      enabled=true exported=true processName=jp.co.omronsoft.openwnn
      permission=android.permission.BIND_INPUT_METHOD
      flags=0x0
com.android.inputmethod.pinyin/.PinyinIME:
  mId=com.android.inputmethod.pinyin/.PinyinIME mSettingsActivityName=com.android.inputmethod.pinyin.SettingsActivity
  mIsDefaultResId=0x7f060000
  Service:
    priority=0 preferredOrder=0 match=0x108000 specificIndex=-1 isDefault=false
    ServiceInfo:
      name=com.android.inputmethod.pinyin.PinyinIME
      packageName=com.android.inputmethod.pinyin
      labelRes=0x7f090000 nonLocalizedLabel=null icon=0x0
      enabled=true exported=true processName=com.android.inputmethod.pinyin
      permission=android.permission.BIND_INPUT_METHOD
      flags=0x0
$

Please confirm what is you want.

review: Needs Fixing
lp://qastaging/~kejun-zhou/lava-android-test/ime updated
152. By Ke Jun ZHOU <dp583@stebjsxu0119>

Change imp.py to:
PATTERN = "^\s*(?P<test_case_id>ime)=(?P<result>\w+)\s*$"

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Except the conflict in 'MANIFEST.in'，
others seems ok for me.
Will resolve the conflict during merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches