Code review comment for lp://qastaging/~kejun-zhou/lava-android-test/pm-qa

On 13 June 2012 21:50, Yongqin Liu <email address hidden> wrote:

> > 24 busybox ln -s -f /system/bin/busybox wc
> > 25
> > 26 export PATH=/data/bin:$PATH
> > 27
> > * 28 cd /system/xbin/pm-qa*
> sorry, missed this line.
>
> And some other things:
> 100 + for dir in `find . -name "*.sh"`
> from the find command, we can see that the output should not be
> directories,
> so use the variable name "dir" is not good I think.

I will update it.

>

> 104 + `echo $SHELL` $path
> The $SHELL veriable seems not defined.
>
$SHELL is defined. In Linaro Android system, it is /system/bin/sh.

> And about this shell script, What do it do?
> What I see is:
> 1. if /system/xbin/pm-qa directory exists, output "pm-qa=pass", otherwise
> output "pm-qa=fail"
> 2. if /system/xbin/pm-qa directory exists, list the sh files in that
> directory.
> Is that right?

If the pm-qa exists, the test will run all the *.sh.

> --
>
> https://code.launchpad.net/~kejun-zhou/lava-android-test/pm-qa/+merge/108892
> You are the owner of lp:~kejun-zhou/lava-android-test/pm-qa.
>