Code review comment for lp://qastaging/~ken-vandine/desktopcouch/desktopcouch-lsof-karmic

Revision history for this message
dobey (dobey) wrote :

I don't understand some of the changes here. You got rid of Tim's code that doesn't use lsof at all, to bring back lsof, but your changes seem to break support for running on Jaunty. The lsof output seems to be different enough between the two, to warrant avoiding using it. Since Tim's code fixed the issue of lsof not working on Karmic, I'm a bit confused about what the rest of the branch is for?

review: Needs Information

« Back to merge proposal