Code review comment for lp://qastaging/~kirkland/maas/1342292

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

On Tue, Jul 15, 2014 at 2:28 PM, Scott Moser <email address hidden> wrote:
> Is there a reason you decided to break if 'echo' is /usr/bin ?
> you're explicitly calling the program 'echo' rather than the sh builtin.
>
> less escaping is done by:
> curtin in-target -- sh -c 'echo "$@" > /etc/apt/apt.conf.d/99translations' -- 'Acquire::Languages "none";'

No reason. I copied some code I found elsewhere to accomplish this.
That's just what was there. And it worked.

> that said, i don't really think this is the right place to work around a squid (or external internet connection) and I really think its not even going to sufficiently work around the issue. It just reduces the number of network connections, possibly reducing failure percentage.

Agreed, this is a horrible place to put this. However, an SE and I
worked 8 hours through the night (Midnight until 8am), trying to
triage and solve this problem before we stumbled into the customer
environment (bleary eyed), and delivered the demo.

All nodes, and the entire environment, is completely unusable and
unworkable until this is disabled.

« Back to merge proposal