lp://qastaging/~kissiel/checkbox/error-logging-in-cbt-fixes
- Get this branch:
- bzr branch lp://qastaging/~kissiel/checkbox/error-logging-in-cbt-fixes
Branch merges
- Zygmunt Krynicki (community): Approve
-
Diff: 50 lines (+13/-5)3 files modifiedcheckbox-touch/components/CheckboxTouchApplication.qml (+4/-0)
checkbox-touch/components/ErrorDialog.qml (+0/-2)
checkbox-touch/components/PythonObjectRef.qml (+9/-3)
Branch information
Recent revisions
- 3923. By Maciej Kisielewski
-
checkbox-touch: handle failed object creation in PythonObjectRef
When creation method call to python failed or misbehaved pyotherside sent in
None as the return value. This was treated as a valid response making
triggering of objectReady signal happen. The worst scenario for this is
PythonLogger construction failing resulting in writes to console.error which in
turn call the 'error' method of the object that is suposed to be a valid python
object, but is None instead.This patch checks if the creation method returned None (or got None because of
python failing) and prevents the objectReady signal from being fired.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3922. By Maciej Kisielewski
-
checkbox-touch: display error popup when session cannot be started
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3921. By Maciej Kisielewski
-
checkbox-touch: fix errorPopup rendering
This patch makes errorPopup render properly. The qml component that was used as
the displayed item had its width and height set to undefined values, making
runtime to set this as 0 resulting in popup's buttons being not visible and the
text being horribly misplaced.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3920. By Maciej Kisielewski
-
"automatic merge of lp:~kissiel/checkbox/validate-providers-in-cbt/ by tarmac [r=zyga]
[bug=][ author= kissiel] " - 3919. By Zygmunt Krynicki
-
"automatic merge of lp:~zyga/checkbox/misc-stuff/ by tarmac [r=sylvain-
pineau] [bug=][ author= zyga]" - 3918. By Sylvain Pineau
-
"automatic merge of lp:~sylvain-pineau/checkbox/fix-1477423/ by tarmac [r=zyga][bug=1477423][author=
sylvain- pineau] " - 3917. By Po-Hsu Lin
-
"automatic merge of lp:~cypressyew/checkbox/fix-fswebcam-format/ by tarmac [r=zyga][bug=1435402][author=
cypressyew] " - 3915. By Maciej Kisielewski
-
"automatic merge of lp:~kissiel/checkbox/confined-qml-jobs/ by tarmac [r=zyga]
[bug=][ author= kissiel] " - 3914. By Maciej Kisielewski
-
"automatic merge of lp:~kissiel/checkbox/rerun-in-cbt/ by tarmac [r=sylvain-
pineau] [bug=][ author= kissiel] "
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/checkbox