Merge lp://qastaging/~kissiel/checkbox/error-logging-in-cbt-fixes into lp://qastaging/checkbox
Proposed by
Maciej Kisielewski
| Status: | Merged |
|---|---|
| Approved by: | Zygmunt Krynicki |
| Approved revision: | 3923 |
| Merged at revision: | 3922 |
| Proposed branch: | lp://qastaging/~kissiel/checkbox/error-logging-in-cbt-fixes |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
50 lines (+13/-5) 3 files modified
checkbox-touch/components/CheckboxTouchApplication.qml (+4/-0) checkbox-touch/components/ErrorDialog.qml (+0/-2) checkbox-touch/components/PythonObjectRef.qml (+9/-3) |
| To merge this branch: | bzr merge lp://qastaging/~kissiel/checkbox/error-logging-in-cbt-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This MR fixes various problems with error loging in checkbox-converged.
3dcdf43 checkbox-touch: fix errorPopup rendering
0324544 checkbox-touch: display error popup when session cannot be started
fe95718 checkbox-touch: handle failed object creation in PythonObjectRef
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, a bit weird on the indent in the middle patch but this aint python, +1