Code review comment for lp://qastaging/~kissiel/checkbox/qml-native

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

FYI:

23:25 < kissiel> zyga, omg
23:25 < kissiel> zyga, i found the problem
23:25 < kissiel> zyga, uncommitted __init__
23:25 < kissiel> in qml_shell module...
23:25 < kissiel> which isn't a module :D
23:26 <@zyga> kissiel: ah
23:26 <@zyga> kissiel: well, python3.4 doesn't need init
23:26 <@zyga> kissiel: so it works there
23:27 < kissiel> zyga, right :)
23:27 <@zyga> kissiel: in 3.2 you still need (even empty) __init__.py

review: Approve

« Back to merge proposal