Code review comment for lp://qastaging/~klmitch/nova/os_int_tests

Revision history for this message
Kevin L. Mitchell (klmitch) wrote :

On Thu, 2011-04-21 at 17:47 +0000, termie wrote:
> Alright, if you are planning on doing tests against live clusters,
> perhaps then look at the smoketests directory. I don't like the name
> of it but it is doing exactly that. I think we'd probably love to get
> your tests in alongside those then, as the existing ones are only
> really testing the ec2 api.

Yeah, that was the one I was worried about when I started this branch.
Because I use a different test infrastructure--for parallelization--I
decided to make it a different directory, though.

> Regarding DTest, it looks nice and we certainly want parallelization
> of tests, but we also are pretty happy with most of what nose gets us,
> what do you think the options are for integration with nose are?

Well, I used nose as one of my sources for ideas and features for DTest.
I know there are some features that don't have equivalents in DTest,
like nose's plug-ins. As for integrating with nose, I haven't looked,
but I suspect it's not going to be possible; even though I've tried to
have similar concepts as unittest and nose, I've deliberately gone with
a completely separate implementation. This allowed me to omit concepts
that didn't make sense (e.g., unittest.TestSuite has no true equivalent
in DTest, and the suite() functions are never called; trying to support
TestSuite or a variant would have complicated DTest too much with too
little benefit, imo). That said, I think most things you may want to be
able to do in nose you can do in DTest, with perhaps a few exceptions (I
don't yet have support for generators yet, for instance).

(BTW, if you see bugs, or think of things that should be in DTest, log
an issue at https://github.com/klmitch/dtest/issues and I'll be happy to
address it :)
--
Kevin L. Mitchell <email address hidden>

« Back to merge proposal