Code review comment for lp://qastaging/~knightrider0xd/openlp/better-sm-preview

Revision history for this message
Ian Knight (knightrider0xd) wrote :

> It works well and I am surprised as I had my doubts for the feature.

Thanks!

> Could we have a race condition where the event fires before the user has
> managed to activate the double click? They are slow between the first and last
> clicks or are the time intervals such that there is no chance of it happening.

The timeout used to determine the difference between a single and double click uses the QApplication.doubleClickInterval().
The Qt documentation (see links) confirms that this uses the system's timeout value for a double click, even if that value is changed while the program is running, so a race condition should not be possible unless there is an issue with Qt.

http://doc.qt.io/qt-5/qapplication.html#details
http://doc.qt.io/qt-5/qapplication.html#doubleClickInterval-prop

« Back to merge proposal