Code review comment for lp://qastaging/~kyrofa/snap-confine/create_user_data_directory

Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Oh my, what a glaring error that was!

Of course you're right Tyler-- the directory creation needs to happen before the apparmor/seccomp confinement, but should definitely happen after the privileges are dropped. My latest push reflects that.

Seth, I believe that actually addresses your concern as well, yes? Since now all mkdir operations are performed with the effective uid of whoever launched it?

« Back to merge proposal