Apport

Merge lp://qastaging/~laney/apport/pkttyagent into lp://qastaging/~ubuntu-core-dev/ubuntu/hirsute/apport/ubuntu

  1. pkttyagent
  2. Merge into ubuntu
Proposed by Iain Lane
Status: Merged
Merged at revision: 2851
Proposed branch: lp://qastaging/~laney/apport/pkttyagent
Merge into: lp://qastaging/~ubuntu-core-dev/ubuntu/hirsute/apport/ubuntu
Diff against target: 113 lines (+58/-2)
2 files modified
apport/hookutils.py (+52/-2)
apport/report.py (+6/-0)
To merge this branch: bzr merge lp://qastaging/~laney/apport/pkttyagent
Reviewer Review Type Date Requested Status
Brian Murray Pending
Ubuntu Core Development Team Pending
Review via email: mp+400664@code.qastaging.launchpad.net

Description of the change

There are two annoying things with this branch that I'd appreciate some help with.

  1) Some dots '.' appear over the prompt. They should be paused while the command is being executed I think.
  2) You get prompted multiple times for your passphrase if there are multiple root commands. I've not verified this but I think probably killing *once* at the end of apport, and not spawning a fresh agent each time, would maybe fix this.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Regarding the dots appearing over the prompt, this has happened for as long as I can remember.

Revision history for this message
Brian Murray (brian-murray) wrote :

I think calling _kill_pttyagent() after calling report.add_hooks_info() would accomplish issue #2.

lp://qastaging/~laney/apport/pkttyagent updated
2852. By Iain Lane

Move pkttyagent killing to add_hooks_info()

This ensures we only kill the agent after all the hooks have been run.

Revision history for this message
Iain Lane (laney) wrote :

Cheers. I did your suggestion but it doesn't fix it. After some further reading it's because we don't allow "auth_admin_keep" for pkexec. I think that's deliberate - or at least should be fixed outside of apport - and this MP lets the information be collected at least.

I think the new method is better though as we avoid spawning it multiple times, which is still nice.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches