Seems to me like this would be a perpetuating a regression that we have since evo switched to a source registry: accounts won't be updated when added/removed or changed.
Consider adding the necesary code to watch the source registry signals described at https://developer.gnome.org/libedataserver/stable/ESourceRegistry.html#ESourceRegistry.signals in place of your TODO at line 688.
Otherwise, looks good :) Since the code itself looks fine and we already have the above regression, I'm approving the merge.
« Back to merge proposal
Seems to me like this would be a perpetuating a regression that we have since evo switched to a source registry: accounts won't be updated when added/removed or changed.
Consider adding the necesary code to watch the source registry signals described at https:/ /developer. gnome.org/ libedataserver/ stable/ ESourceRegistry .html#ESourceRe gistry. signals in place of your TODO at line 688.
Otherwise, looks good :) Since the code itself looks fine and we already have the above regression, I'm approving the merge.