Merge lp://qastaging/~larsu/evolution-indicator/messaging-menu-fixes into lp://qastaging/evolution-indicator
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~larsu/evolution-indicator/messaging-menu-fixes |
| Merge into: | lp://qastaging/evolution-indicator |
| Diff against target: |
993 lines (+172/-550) 3 files modified
configure.ac (+1/-1) src/evolution-indicator.c (+169/-548) src/org-freedesktop-evolution-indicator.eplug.xml (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~larsu/evolution-indicator/messaging-menu-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2013-03-18.
Description of the change
A couple of minor fixes to lp:~twolife/evolution-indicator/eds-3.6_messaging-menu that I found while testing.
| Lars Karlitski (larsu) wrote | # |
| Mathieu Trudel-Lapierre (cyphermox) wrote | # |
| Lars Karlitski (larsu) wrote | # |
| Sebastien Bacher (seb128) wrote | # |
Unmerged revisions
- 103. By Lars Karlitski
-
Use new-style GtkBox constructors
- 102. By Lars Karlitski
-
Declare update_
unity_launcher_ count before first use - 101. By Lars Karlitski
-
e_plugin_
get_configure_ widget: return NULL instead of an empty widget To get rid of warnings about deprecated gtk functions.
- 100. By Lars Karlitski
-
Use GMutex instead of the deprecated GStaticMutex
- 99. By Lars Karlitski
-
Update the list of accounts on-the-fly
We don't need any information about sources until new messages arrive. Create
the account objects then, instead of listening to "source-added" and
"source-removed" signals. - 98. By Lars Karlitski
-
Remove n_accounts global variable
It gets in the way of the next patch.
- 97. By Lars Karlitski
-
Use evolution's uids instead of self-assembled urls as message source identifiers
This simplifies the code and fixes a bug: all POP accounts got the url "pop:",
making them show up as the same entry in the messaging menu. - 96. By Lars Karlitski
-
update_accounts: fix memory leak
- 95. By Lars Karlitski
-
update_accounts: move name and url fetching into separate function
Also removes some unnecessary string allocations and a memory leak.
- 94. By Lars Karlitski
-
update_accounts: recreate accounts list from scratch
This function is only ever called when the global 'accounts' list is NULL,
there's no need to check for existing accounts.
Seems to me like this would be a perpetuating a regression that we have since evo switched to a source registry: accounts won't be updated when added/removed or changed.
Consider adding the necesary code to watch the source registry signals described at https:/
Otherwise, looks good :) Since the code itself looks fine and we already have the above regression, I'm approving the merge.