Code review comment for lp://qastaging/~larsu/libindicator/new-indicator-file-format

Revision history for this message
Ted Gould (ted) wrote :

It seems odd to me to check state using g_assert() instead of g_return_if_fail(). Both generate critical errors, but one doesn't crash the whole panel service. I don't see the benefit of crashing the whole panel service.

review: Needs Information

« Back to merge proposal