libindicator

Merge lp://qastaging/~larsu/libindicator/per-profile-positions into lp://qastaging/libindicator/13.10

per-profile-positions
Merge into trunk.13.10

Proposed by Lars Karlitski on 2013-10-10

Status:	Superseded
Proposed branch:	lp://qastaging/~larsu/libindicator/per-profile-positions
Merge into:	lp://qastaging/libindicator/13.10
Diff against target:	13 lines (+3/-0) 1 file modified libindicator/indicator-ng.c (+3/-0)
To merge this branch:	bzr merge lp://qastaging/~larsu/libindicator/per-profile-positions
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ted Gould (community)		2013-10-10	Approve on 2013-10-14
PS Jenkins bot (community)	continuous-integration		Approve on 2013-10-10
Review via email: mp+190464@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2013-10-17.

Commit message

Allow setting different positions for each profile in indicator files

The 'Position' key in a profile section has precedence over the global 'Position' key, but otherwise the same semantics.

Description of the change

Allow setting different positions for each profile in indicator files

The 'Position' key in a profile section has precedence over the global 'Position' key, but otherwise the same semantics.

We need this along with lp:~larsu/unity8/per-profile-indicator-positions to enable different positioning on the desktop and phone.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-10-10:

PASSED: Continuous integration, rev:513
http://jenkins.qa.ubuntu.com/job/libindicator-ci/44/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/30/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/libindicator-ci/44/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ted Gould (ted) wrote on 2013-10-14:

The code looks fine. I don't think we're going to be able to update the indicators themselves for 14.04 so I'm going to not top approve. Not a string feeling, but thinking we can wait on it.

review: Approve