libindicator

Merge lp://qastaging/~larsu/libindicator/per-profile-positions into lp://qastaging/libindicator/14.04

  1. per-profile-positions
  2. Merge into trunk.14.04
Proposed by Lars Karlitski
Status: Merged
Approved by: Charles Kerr
Approved revision: 513
Merged at revision: 516
Proposed branch: lp://qastaging/~larsu/libindicator/per-profile-positions
Merge into: lp://qastaging/libindicator/14.04
Diff against target: 13 lines (+3/-0)
1 file modified
libindicator/indicator-ng.c (+3/-0)
To merge this branch: bzr merge lp://qastaging/~larsu/libindicator/per-profile-positions
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Charles Kerr (community) Approve
Ted Gould Pending
Review via email: mp+191712@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-10-10.

Description of the change

Allow setting different positions for each profile in indicator files

The 'Position' key in a profile section has precedence over the global 'Position' key, but otherwise the same semantics.

We need this along with lp:~larsu/unity8/per-profile-indicator-positions to enable different positioning on the desktop and phone.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:513
http://jenkins.qa.ubuntu.com/job/libindicator-ci/44/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/30/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/libindicator-ci/44/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

The code looks fine. I don't think we're going to be able to update the indicators themselves for 14.04 so I'm going to not top approve. Not a string feeling, but thinking we can wait on it.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:513
http://jenkins.qa.ubuntu.com/job/libindicator-ci/47/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/33/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/libindicator-ci/47/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Top approving for 14.04 now that we've branched

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches