Merge lp://qastaging/~linaro-infrastructure/linaro-ci/fix_bug_912151 into lp://qastaging/linaro-ci

Proposed by Deepti B. Kalakeri
Status: Merged
Merged at revision: 47
Proposed branch: lp://qastaging/~linaro-infrastructure/linaro-ci/fix_bug_912151
Merge into: lp://qastaging/linaro-ci
Diff against target: 17 lines (+6/-1)
1 file modified
jenkins_kernel_build_inst (+6/-1)
To merge this branch: bzr merge lp://qastaging/~linaro-infrastructure/linaro-ci/fix_bug_912151
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+87588@code.qastaging.launchpad.net

Description of the change

vmlinuz name is now expected to end linaro-lt-omap for panda instead of just linaro-omap.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Are we certain that only omap3 hwpacks need the name to be "linaro-{flavour}" and everything else needs "linaro-lt-{flavour}": your description above suggests only Panda should use "linaro-lt", so I just wanted to check?

review: Needs Information
Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

> Are we certain that only omap3 hwpacks need the name to be "linaro-{flavour}"
> and everything else needs "linaro-lt-{flavour}": your description above
> suggests only Panda should use "linaro-lt", so I just wanted to check?

Yes, I have checked the latest omap3 hwpacks available on s.l.o and the vmlinuz have an extension of linaro-{flavour} unlike panda hwpacks where the hwpacks have "linaro-lt-{flavour}".

I do not have correct details for origen boards as of now. They previously worked with the "linaro-{flavour}" extension. I believe now the origen hwpacks vmlinuz just end with {falvour} in their name. But, since yesterday I am not successful in using the the latest origen hwpack as it is failing with l-m-c. If you think I should make the changes for the origen board as well I can do it, but I cannot guarantee the testing aspect of it. Do you think otherwise ?

Thanks!!!
Deepti.

Revision history for this message
Данило Шеган (danilo) wrote :

No, let's do everything step at the time.

However, I am asking because previous code was using "{config}-linaro-{flavour}" for everything, and you are now changing it to be "{config}-linaro-lt-{flavour}" for *everything* except omap3. Does it not make more sense to explicitely check for panda instead?

48. By Deepti B. Kalakeri

Verify if the hwpack is for panda specifically

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

> No, let's do everything step at the time.
>
> However, I am asking because previous code was using
> "{config}-linaro-{flavour}" for everything, and you are now changing it to be
> "{config}-linaro-lt-{flavour}" for *everything* except omap3. Does it not
> make more sense to explicitely check for panda instead?

Done, please review the changes.

Thanks!!!
Deepti.

Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, thanks.

review: Approve
Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

Thanks!
Deepti.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches