Code review comment for lp://qastaging/~liuyq0307/lava-android-test/v8-skia
Revision history for this message
| Yongqin Liu (liuyq0307) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f399f05
demo site
(Get the code!)
> v8.py has:
>
> 154 -ADB_SHELL_STEPS = ['"cd /data/benchmark/v8; v8shell run.js"']
> 155 +adb_shell = ('"'
> 156 + 'cd /data/benchmark
> 157 + 'if which v8shell 2>/dev/null 1>/dev/null;'
> 158 + 'then v8shell run.js; '
> 159 + 'else d8 run.js; fi'
> 160 + '"')
> 161 +ADB_SHELL_STEPS = [adb_shell]
>
> that's a little awkward,
Yes, I know this is not good.
but we need all the shell steps in one string.
then we can run it as adb shell "shell steps".
if we change it to ADB_SHELL_STEPS = [steps1, steps2,..], this will not work.
> since shell steps can be an array this could be
> broken up into multiple strings
sorry, not understand clearly here.
in which case it will be broken up?