Code review comment for lp://qastaging/~liuyq0307/lava-master-image-scripts/fix-trap-on-exit

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yongqin Liu <email address hidden> writes:

> $ /bin/sh -c "trap EXIT"
> trap: usage: trap [-lp] [[arg] signal_spec ...]
> $ bash -c "trap EXIT"
> $ dash -c "trap EXIT"
> $ ll /bin/sh
> lrwxrwxrwx 1 root root 9 6月 25 13:37 /bin/sh -> /bin/bash*
> $ trap EXIT
> $
>
> seems only the sh link has problems

Hah, so I can reproduce this:

mwhudson@narsil:devel$ ln -s /bin/bash ~/bin/sh
mwhudson@narsil:devel$ ~/bin/sh -c "trap EXIT"
trap: usage: trap [-lp] [[arg] signal_spec ...]

A bug in bash's bourne shell mode or something?

Anyway, please merge this branch.

Cheers,
mwh

« Back to merge proposal