Code review comment for lp://qastaging/~liuyq0307/linaro-android-build-tools/run-custom

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Now, another issue is that the changes appear to be big and complicated. Thanks much for making https://wiki.linaro.org/Platform/Android/AndroidBuild-LavaIntegration - that helps a lot. But then it just proves that solution proposed is too complex UI-wise. One of the main requirements for android-build's build configs is that they are clean and simple, essentially one should be just able to look at it and immediately grasp what the build does.

The example as shown on https://wiki.linaro.org/Platform/Android/AndroidBuild-LavaIntegration is very complicated, there's no way one can grasp what it is without studying docs and then carefully peering into that config for a while, nor it could be easily and safely changed - there's high probability of error. So, sorry, but this needs more work, and first of all, consideration of UI and syntax for such custom tests. Let me take it to the mailing list for discussion (need to ponder about it a bit first, to propose alternative).

review: Disapprove

« Back to merge proposal