Charm Helpers

Code review comment for lp://qastaging/~lomov-as/charm-helpers/cloud-foundry

  1. cloud-foundry
  2. Merge into cloud-foundry
Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM, thanks!

lbox submit

should merge this for you

https://codereview.appspot.com/88870043/diff/1/charmhelpers/contrib/cloudfoundry/upstart_helper.py
File charmhelpers/contrib/cloudfoundry/upstart_helper.py (right):

https://codereview.appspot.com/88870043/diff/1/charmhelpers/contrib/cloudfoundry/upstart_helper.py#newcode10
charmhelpers/contrib/cloudfoundry/upstart_helper.py:10: dirname =
os.path.join(hookenv.charm_dir(), 'files/upstart')
Thanks for fixing this. Much better not to run that code on import

https://codereview.appspot.com/88870043/

Reply

« Back to merge proposal