Merge lp://qastaging/~lool/ubuntuone-client/tritcask-use-platform-api into lp://qastaging/ubuntuone-client
Proposed by
Loïc Minier
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 1400 | ||||
Merged at revision: | 1387 | ||||
Proposed branch: | lp://qastaging/~lool/ubuntuone-client/tritcask-use-platform-api | ||||
Merge into: | lp://qastaging/ubuntuone-client | ||||
Diff against target: |
262 lines (+52/-26) 7 files modified
ubuntuone/platform/__init__.py (+1/-0) ubuntuone/platform/os_helper/__init__.py (+1/-0) ubuntuone/platform/os_helper/darwin.py (+1/-0) ubuntuone/platform/os_helper/linux.py (+1/-0) ubuntuone/platform/os_helper/unix.py (+5/-0) ubuntuone/platform/os_helper/windows.py (+6/-0) ubuntuone/syncdaemon/tritcask.py (+37/-26) |
||||
To merge this branch: | bzr merge lp://qastaging/~lool/ubuntuone-client/tritcask-use-platform-api | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike McCracken (community) | Approve | ||
dobey (community) | Approve | ||
Review via email: mp+147581@code.qastaging.launchpad.net |
Commit message
Use platform API for os.path.* functions; fixes LP #1101344.
Description of the change
Use platform API for os.path.* functions; fixes bug #1101344.
To post a comment you must log in.
Pushed some more revisions; sorry, there's some history garbage: r1387 to r1390 were attempts to fix the SetFileSecurity issue: yInfo function
* it's a deprecated function, so I tried using the new SetNamedSecurit
* I also tried matching permissions with files on my system which have an ACL entry for sysops too
* I dropped some unused function (_get_group_sid)
but I didn't want these revs to end up in this mp, and I forgot to revert my tree to the right revno before committing the other fixes, so r1391 has these changed reverted.
Let me know if you'd like some of them in another mp, but they don't fix the orginal bug so I'm not adding them here.