Code review comment for lp://qastaging/~lool/ubuntuone-client/tritcask-use-platform-api

Revision history for this message
Loïc Minier (lool) wrote :

Sorry I hadn't (I thought I had noted that, but apparently I forgot)

I've pushed r1398 which fixes this particular issue, and then make check exposed another issue which I've fixed in r1399; this should hopefully be good to merge now. NB: some tests were actually skipped, not sure why:
PASSED (skips=12, successes=2759)

Also didn't run some part of the tests it seems:
ubuntuone.devtools.errors.TestError: The Python package providing the requested reactor is not installed. You can find it here: https://github.com/ghtdak/qtreactor

[ Would you mind adding some advice in HACKING on the packages that one should install? I had to install:
  xutils-dev gobject-introspection python-mocker
to run ./autogen.sh && make check, and I can see that other bits like gnome-common are needed. ]

« Back to merge proposal