Merge lp://qastaging/~lukas-kde/unity8/stagedCloseShortcut into lp://qastaging/unity8
Proposed by
Lukáš Tinkl
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Michael Terry | ||||||||
| Approved revision: | 2419 | ||||||||
| Merged at revision: | 2554 | ||||||||
| Proposed branch: | lp://qastaging/~lukas-kde/unity8/stagedCloseShortcut | ||||||||
| Merge into: | lp://qastaging/unity8 | ||||||||
| Diff against target: |
178 lines (+63/-12) 5 files modified
qml/Stages/AbstractStage.qml (+9/-0) qml/Stages/DesktopStage.qml (+8/-8) qml/Stages/PhoneStage.qml (+8/-2) qml/Stages/TabletStage.qml (+8/-2) tests/qmltests/tst_Shell.qml (+30/-0) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~lukas-kde/unity8/stagedCloseShortcut | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Michał Sawicz | Needs Fixing | ||
| Michael Terry | Approve | ||
|
Review via email:
|
|||
Commit message
Provide window/surface close shortcuts across all the stages
Description of the change
Provide window/surface close shortcuts across all the stages
Fixed bug lp:1578392
Also, in desktop stage, prevent dash from being closed using this shortcut
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Lukáš Tinkl (lukas-kde) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Lukáš Tinkl (lukas-kde) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Michael Terry (mterry) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Lukáš Tinkl (lukas-kde) wrote | # |
Revision history for this message
| Lukáš Tinkl (lukas-kde) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Lukáš Tinkl (lukas-kde) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:2412
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/